Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BW Rendering #252

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Implement BW Rendering #252

wants to merge 9 commits into from

Conversation

ExE-Boss
Copy link
Member

@ExE-Boss ExE-Boss commented Jan 17, 2017 •
edited
Loading

This PR implements backward rendering of Minecraft 1.8 blocks and items.

Depends on:

To do:

  • Test 1.7
    • Items
    • Blocks
    • Entities
  • Test 1.8
    • Items
    • Blocks
      • Tile Entities
    • Entities
  • Entities (Will need a 1.7 and 1.8 implementation)

Completed:

Moved to #283:

  • Implement a MeshModel wrapper (BWBakedModel) for Minecraft's IBakedModel
    • Render correctly for Items
    • Render correctly for Blocks
  • Make 1.8 BWBakedModel parse according to VertexFormat.

Closes #104, Fully implements #153

@ExE-Boss ExE-Boss added feature in progress Pull requests that are not yet ready to be merged and issues that are being worked on. minecraft 1.8 Affects Minecraft 1.8.x wrappers labels Jan 17, 2017
@ExE-Boss ExE-Boss self-assigned this Jan 17, 2017
@ExE-Boss ExE-Boss added this to the v0.1.0 milestone Jan 17, 2017
@codecov-io
Copy link

codecov-io commented Jan 17, 2017 •
edited
Loading

Codecov Report

Merging #252 into master will decrease coverage by -0.25%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #252      +/-   ##
============================================
- Coverage     13.38%   13.14%   -0.25%     
  Complexity      679      679              
============================================
  Files           403      404       +1     
  Lines         12078    12301     +223     
  Branches       1296     1313      +17     
============================================
  Hits           1617     1617              
- Misses        10362    10585     +223     
  Partials         99       99
Impacted Files Coverage Δ Complexity Δ
.../mc/forge/v18/wrapper/render/FWSmartItemModel.java 0% <ø> (ø) 0 <0> (ø) ❌
...mc/forge/v18/wrapper/render/FWSmartBlockModel.java 0% <ø> (ø) 0 <0> (ø) ❌
...rc/main/java/nova/core/render/model/MeshModel.java 10.81% <ø> (ø) 0 <0> (ø) ❌
src/main/java/nova/core/render/model/Face.java 0% <ø> (ø) 0 <0> (ø) ❌
.../main/java/nova/core/render/model/CustomModel.java 0% <ø> (ø) 0 <0> (ø) ❌
...pper/mc/forge/v18/wrapper/render/FWEmptyModel.java 0% <ø> (ø) 0 <0> (ø) ❌
...e/wrapper/mc/forge/v17/wrapper/render/BWModel.java 0% <0%> (ø) 0 <0> (ø) ❌
...core/wrapper/mc/forge/v18/wrapper/item/BWItem.java 0% <0%> (ø) 0 <0> (ø) ❌
...e/wrapper/mc/forge/v18/wrapper/render/BWModel.java 0% <0%> (ø) 0 <0> (ø) ❌
src/main/java/nova/core/render/model/Vertex.java 0% <0%> (ø) 0 <0> (ø) ❌
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50e502...08b1952. Read the comment docs.

@ExE-Boss ExE-Boss requested review from calclavia and RX14 January 19, 2017 23:48
RX14
RX14 suggested changes Feb 12, 2017
View reviewed changes
...t/1.8/src/main/java/nova/core/wrapper/mc/forge/v18/wrapper/render/BWClientRenderManager.java Outdated
@@ -37,6 +38,13 @@
* @author Calclavia
*/
public class BWClientRenderManager extends BWRenderManager {

//TODO: Would this break server?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling this method on a server causes a crash

@RX14
Copy link
Contributor

RX14 commented Feb 12, 2017

Merge conflict.

RX14
RX14 suggested changes Feb 24, 2017
View reviewed changes
Copy link
Contributor

@RX14 RX14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing required

@ExE-Boss ExE-Boss mentioned this pull request Feb 26, 2017
Merged
@ExE-Boss ExE-Boss force-pushed the bw-renderer branch 4 times, most recently from d99d129 to 31ff5d4 Compare March 2, 2017 22:31
@ExE-Boss ExE-Boss mentioned this pull request Mar 3, 2017
Merged
5 tasks
@ExE-Boss ExE-Boss added the rebase needed 🚧 This PR needs to resolve a merge conflict label Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 requested changes

@calclavia calclavia Awaiting requested review from calclavia

Assignees

@ExE-Boss ExE-Boss

Labels
feature in progress Pull requests that are not yet ready to be merged and issues that are being worked on. minecraft 1.8 Affects Minecraft 1.8.x wrappers rebase needed 🚧 This PR needs to resolve a merge conflict
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ExE-Boss @codecov-io @RX14