Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to have getID() in block, because you can have different instance of block, and have them considered as different types.
It makes more sense to have IDs in factories, because factories are what determines the type of block/entity/item, not the instance itself.
E.g: It doesn't make sense as we're registering instances of TE essentially as a specific type.
Before
ID used to be specified in block instances, which does not make sense.
After
New registration pattern for blocks, items and entities:
Example:
TODO: #196