Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dummies, switch component to DI. Resolves #102 #190

Merged
merged 6 commits into from
Sep 10, 2015
Merged

Remove dummies, switch component to DI. Resolves #102 #190

merged 6 commits into from
Sep 10, 2015

Conversation

calclavia
Copy link
Member

  • Removes dummies from factories
  • Changed components to use DI
  • Added processors to Factories

TODO: #196

@calclavia calclavia added the in progress Pull requests that are not yet ready to be merged and issues that are being worked on. label Sep 10, 2015
@codecov-io
Copy link

Current coverage is 12.41%

Merging #190 into master will increase coverage by +0.04% as of 4b89a49

@@            master    #190   diff @@
======================================
  Files          386     389     +3
  Stmts        10399   10396     -3
  Branches      1490    1486     -4
  Methods          0       0       
======================================
+ Hit           1287    1291     +4
- Partial         75      76     +1
+ Missed        9037    9029     -8

Review entire Coverage Diff as of 4b89a49

Powered by Codecov. Updated on successful CI builds.

@calclavia calclavia changed the title Remove dummies Remove dummies, switch component to DI. Resolves #102 Sep 10, 2015
calclavia added a commit that referenced this pull request Sep 10, 2015
@calclavia
Merge pull request #190 from NOVA-Team/remove-dummy-objects
50626eb 
Removed dummies, switch component to DI. Resolves #102
@calclavia calclavia merged commit 50626eb into master Sep 10, 2015
@calclavia calclavia removed the in progress Pull requests that are not yet ready to be merged and issues that are being worked on. label Sep 10, 2015
@calclavia calclavia deleted the remove-dummy-objects branch September 10, 2015 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calclavia @codecov-io