Block component and Block event adding is inconsistent

[calclavia]

To add an event you use events.on() but to add components you don't use components.add() but add(). Small inconsistency, both things seem like a similar thing, but are done in a different way. Would be logical to have them both be add() and on() or like the first line.

[RX14]

I would say there should be a component container for each block, which is called components instead of block extending components container...

[gjgfuj]

Yeah. A components.add would make a lot more sense imo.

On Mon, 29 Jun 2015 11:24 pm Chris Hobbs [email protected] wrote:

I would say there should be a component container for each block, which is
called componets instead of block extending components container...

—
Reply to this email directly or view it on GitHub
#133 (comment)
.

[calclavia]

Should we do components.add or change block to have "on" function?

I can make ComponentProvider extend EventBus.

[RX14]

What? Why would componentprovider extend event bus? There just needs to be a component provider named components as a field for each block.

[calclavia]

@RX14 Agreed. Will work on this.

[calclavia]

TODO: #196

[codecov-io]

Current coverage is 12.95%

Merging #133 into master will increase coverage by +0.13% as of 5828a90

@@            master    #133   diff @@
======================================
  Files          391     391       
  Stmts        10411   10413     +2
  Branches      1488    1488       
  Methods          0       0       
======================================
+ Hit           1335    1349    +14
+ Partial         76      75     -1
+ Missed        9000    8989    -11

Review entire Coverage Diff as of 5828a90

Powered by Codecov. Updated on successful CI builds.