-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1pt] Implement denylist for flow-based CatFIM #1413
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilyDeardorff
changed the title
WIP [1pt] Implement denylist for flow-based CatFIM
[1pt] Implement denylist for flow-based CatFIM
Jan 25, 2025
RobHanna-NOAA
approved these changes
Jan 31, 2025
CarsonPruitt-NOAA
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a denylist for flow-based CatFIM (that uses the same conventions as the existing denylist functionality used in stage-based CatFIM. Adds CMUG1 to the denylist for flow-based CatFIM.
Additions
tools/catfim/ahps_restricted_sites.csv
: Renamed fromstage_based_ahps_restricted_sites.csv
. Added an additional column,catfim_type
, that specifies whether a site should be restricted for flow-based CatFIM (flow
), stage-based CatFIM (stage
), or both (both
). Added CMUG1 as another restricted site. Changed a number of sites that were previously just restricted for stage-based CatFIM to be restricted for both.Changes
tools/catfim/generate_categorical_fim.py
: Facilitate sites filtration in flow-based CatFIM processing. Update theload_restricted_sites()
function to handle restricted sites for both flow- and stage-based CatFIM. Clean up a few comments.tools/catfim/generate_categorical_fim_flows.py
: Add restricted sites filtration to flow-based CatFIM processing.Removals
tools/catfim/stage_based_ahps_restricted_sites.csv
: Renamed toahps_restricted_sites.csv
Testing
Deployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally4.x.x.x
Merge Checklist (For Technical Lead use only)