Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Adding CI check for linted files. If a PR is open with code that … #4

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

JuLieAlgebra
Copy link
Member

…is not compliant with the linters, it will fail this status check. Please see comments in workflow or docs/setup.md for how to ensure your linters are installed and running on commit

@JuLieAlgebra
Copy link
Member Author

Commit history of demoing that the CI check works (going to squash the demo commits):
image

Example of what it will look like for your code to fail the CI linter check:
image

…is not compliant with the linters, it will fail this status check. Please see comments in workflow or docs/setup.md for how to ensure your linters are installed and running on commit

bugfix: Known issue in pre-commit with not found python interpreter, changing language version in precommit config file to reflect python version used for CI

CI check: This commit should fail the CI linter check as it's not ruff-compliant

CI: Undoing the demonstration for the CI linter check
@JuLieAlgebra JuLieAlgebra force-pushed the jbacon_linter_ci_check branch from 8448e64 to f739771 Compare February 12, 2024 19:20
Copy link
Collaborator

@SooluThomas SooluThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you for adding

@SooluThomas SooluThomas merged commit 58ddf3d into main Feb 15, 2024
2 checks passed
@SooluThomas SooluThomas deleted the jbacon_linter_ci_check branch February 15, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants