Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile Module Versions #84

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

oelbert
Copy link
Contributor

@oelbert oelbert commented Apr 24, 2024

Description
The dockerfile reinstalls some python modules (numpy, mpi4py and netcdf) with specific versions hardcoded, and the netcdf4 and numpy versions are incompatible. None of these reinstalls are necessary anyway so I'm taking them out of the dockerfile.

Fixes # (issue)
Didn't log it, sorry

How Has This Been Tested?
Checked that everything runs from a fresh docker image build

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmalatino fmalatino merged commit fa6097e into NOAA-GFDL:develop Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants