-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/ndsl #57
Merged
Merged
Refactor/ndsl #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tmp reqs file for NDSL Updated dependencies for other packages
Move out translate test back to Physics
Fix physics local import
fmalatino
added a commit
that referenced
this pull request
Feb 2, 2024
* Refactor/ndsl (#57) * Move `pace.dsl` to local `ndsl.dsl` * Replacing gt4py_utils.halo by pace.util.N_HALO_DEFAULT * Move .gitmodules out of main pace Tmp reqs file for NDSL Updated dependencies for other packages * pace.stencils -> ndsl.stencils * Moved Dycore<>Physics bridge out of `ndsl` Move out translate test back to Physics * Fix driver reference to update_atmos_state * Remove pace.stencils * pace.util -> ndsl.util * Move util test & examples * Delete pace.util * Rely on ndsl submodule * Lint (for import order) * Remove unused import, fix missing import * Restore gitmodule strategy * Update requitements of model packages * Moved translate_driver into Pace/tests Fix physics local import * Lint (couple of type ignore on bad ENUM read) * Push c12_restart * Bad restart path * Bad path * Better pre-commit * [Flatten util]: `ndsl.util.halo` dir for halo tools. * Moved performance collection tooling and SDFG tools (tools.py) driver/pace/driver/performance -> ndsl/performance * [Flatten util]: comms, paritioner & mpi into `utils.comm` * Move _xarray into optional_imports and delete file * Move dsl test to `ndsl` * Updates to files using performance tools to point to the ndsl module * Move boundary in .comm * Lint & remove caputre_steam * Remove unused `_corners` * Move `profiler` in `ndsl.performance` * Moved `util._timing` in `performance.timer` * `pace_log` -> `ndsl_log` * Remove `util.nudging` * Changes to files contained in examples to reflect addition of ndsl * `_optional_imports` -> `optional_imports` * `_exceptions` -> `exceptions` * Remove `time` * Move restart_properties yaml to restart folder * Minor import tweaks * [Flatten util] Move all util subdirectories into `ndsl` * Fix reference to long delete fortran prop structure * Additional lint * [Flatten util] Further import cleanup * Additional lint * Removed ndsl and added NDSL submodule * Updates to setup.py for fv3core and physics to remove outdated dependencies * Updated constraints.txt due to NDSL as submodule * Updating NDSL * Updated constraints.txt * Linting import orders * Cleanup of *.pyc files in NDSL * Update constraints.txt in attempt to fix github workflow environment * Update main_unit_tests.yml * Update main_unit_tests.yml, change to upgrade pip, setuptools, wheel --------- Co-authored-by: Florian Deconinck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First batch of file move & rename