Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update.readme #6

Merged
merged 15 commits into from
Aug 7, 2024
Merged

Update.readme #6

merged 15 commits into from
Aug 7, 2024

Conversation

ilaflott
Copy link
Member

No description provided.

ilaflott added 3 commits July 25, 2024 14:18
move current README to be a fre-cli-flavored README
add old instructions with rose and stuff... etc.
Copy link
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ian for starting this needed documentation. It's tough as we haven't done it so far in part because this "workflow definition" repository is not usable without fre-cli. Should "how to postprocess fms history files" be in this repository or in fre-cli?

this is in the right direction, thanks!

@ilaflott ilaflott marked this pull request as ready for review July 29, 2024 23:52
Copy link
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this is going but it needs some work.

We're not using the Rose optional configurations any longer so some of the steps can be simplified.

Should we document how to create the rose-suite.conf and rose-app.conf's manually, or only document how to use fre pp configure-yaml?

@ilaflott
Copy link
Member Author

> We're not using the Rose optional configurations any longer so some of the steps can be simplified.
shall remove!

> Should we document how to create the rose-suite.conf and rose-app.conf's manually, or only document how to use fre pp configure-yaml?
was thinking that we should link fre pp's README, somewhere- the logic being that if someone is looking at this repo and wondering... "shouldn't this be a little bit easier?", they're probably actually looking for fre-cli and somehow ended up here, in fre-workflows

ilaflott added 12 commits July 31, 2024 08:31
no longer using a submodule approach
formatting and edits, clean up.
another pass- more formatting, backticks for code objects or variables or field values etc. break up some long lines.
intermediate commit
another intermediate commit for sanity
getting there... should be good for trying to use this tomorrow and conduct tweaks/fix issues with my wording/descriptions etc.
fix subsection
another pass
another iteration. adding in a few settings... static component maybe should be taken out, the logic seems wrong for the task dependence and i dont want to show that here.
one more tweak, up next, one more test start-to-end
@ilaflott
Copy link
Member Author

ilaflott commented Aug 7, 2024

Good enough for now. Illustrates what the user needs to pay attention to, and the instructions are copy/paste oriented enough.

A problem for an issue+PR: statics processing task-dependence is not right
Screen Shot 2024-08-07 at 12 59 11 PM
. #8

@ilaflott ilaflott merged commit 138600c into main Aug 7, 2024
@ilaflott ilaflott deleted the update.README branch August 7, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants