Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containerized CI and reusable workflow implementation #24

Merged
merged 95 commits into from
Jun 27, 2024
Merged

Containerized CI and reusable workflow implementation #24

merged 95 commits into from
Jun 27, 2024

Conversation

mlee03
Copy link
Contributor

@mlee03 mlee03 commented Jun 11, 2024 •
edited
Loading

Description
In this PR, the CI workflow is changed to run in a container. The image is built from a base miniforge image. GNU compilers, netCDF and HDF5 libraries, and MPICH have been installed. The default python version is set to 3.11.7.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • Targeted model if this changed was triggered by a model need/shortcoming

mlee03 and others added 30 commits June 11, 2024 10:34
FlorianDeconinck
FlorianDeconinck previously approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fmalatino
fmalatino previously approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mlee03 mlee03 changed the title Containerized CI Containerized CI and reusable workflow implementation Jun 20, 2024
xyuan
xyuan previously approved these changes Jun 21, 2024
View reviewed changes
oelbert
oelbert previously approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

fmalatino
fmalatino reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tests may be failing because numpy needs to be pinned to 1.26.4

fmalatino
fmalatino approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmalatino fmalatino merged commit 8d59c1e into NOAA-GFDL:develop Jun 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmalatino fmalatino fmalatino approved these changes

@oelbert oelbert oelbert left review comments

@FlorianDeconinck FlorianDeconinck FlorianDeconinck left review comments

@xyuan xyuan xyuan left review comments

@bensonr bensonr Awaiting requested review from bensonr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mlee03 @xyuan @FlorianDeconinck @oelbert @fmalatino