Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HUGE_R to dsl Float type for mixed precision #20

Merged
merged 4 commits into from
May 22, 2024

Conversation

fmalatino
Copy link
Contributor

@fmalatino fmalatino commented May 16, 2024

Description
This commit makes HUGE_R a Float dsl type for mixed precision functionality

How Has This Been Tested?
Tested by implemented unit tests
Use in builds of pace and pySHiELD and their unit tests

Should be reviewed after PR 43 in NDSL

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • Targeted model if this changed was triggered by a model need/shortcoming

@fmalatino fmalatino marked this pull request as ready for review May 17, 2024 19:14
setup.py Outdated Show resolved Hide resolved
@fmalatino fmalatino marked this pull request as draft May 20, 2024 17:33
@FlorianDeconinck FlorianDeconinck marked this pull request as ready for review May 20, 2024 17:36
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmalatino fmalatino changed the title Casting HUGE_R to dsl Float type for mixed precision HUGE_R to dsl Float type for mixed precision May 20, 2024
Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FlorianDeconinck FlorianDeconinck merged commit b4a5d97 into NOAA-GFDL:develop May 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants