-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boilerplate code for fast deploy of NDSL #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would we have a util directory, and put all these utility code there instead of ndsl directory?
I personally don't like |
sure, that makes sense, thanks
…On Wed, May 15, 2024 at 9:54 AM Florian Deconinck ***@***.***> wrote:
I personally don't like util directories as they become a dumping ground
for everything and anything quickly (we use to have one we clean up with
Frank). Each tools & features should be named with what they do
—
Reply to this email directly, view it on GitHub
<#39 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFCG2D7RP2G7YUOGCUK3Y3ZCNSKBAVCNFSM6AAAAABHWLWJDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGYYTAOBZGE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Small suggestion if you want for names.
Is part of the thinking that we will end up making a similar function for gpu orchestrated backends and others?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Description
In order to present an unified, easy and clean API to the user, we start here a series of "boilerplate" code that wrap common use cases. The first of those is the "quick test" with a one tile, no boundaries, no comms, for
numpy
andorchestrated dace:cpu
How Has This Been Tested?
Adding two boilerplate code
Checklist: