Passing shelf_sfc_mass_flux to ice shelf #818
Conversation
* Removed second registration of sfc_mass_flux with register_diag_field. * Registered sfc_mass_flux to runs with static and dynamic ice sheets.
Merge remote-tracking branch 'gfdl/dev/gfdl' into dev/cryo
…gister_diag_field()'
| @@ -1962,9 +1962,6 @@ subroutine initialize_ice_shelf(param_file, ocn_grid, Time, CS, diag, Time_init, | |||
| 'ice shelf thickness', 'm', conversion=US%Z_to_m) | |||
| CS%id_dhdt_shelf = register_diag_field('ice_shelf_model', 'dhdt_shelf', CS%diag%axesT1, CS%Time, & | |||
| 'change in ice shelf thickness over time', 'm s-1', conversion=US%Z_to_m*US%s_to_T) | |||
| CS%id_mass_flux = register_diag_field('ice_shelf_model', 'mass_flux', CS%diag%axesT1,& | |||
| CS%Time, 'Total mass flux of freshwater across the ice-ocean interface.', & | |||
| 'kg/s', conversion=US%RZ_T_to_kg_m2s*US%L_to_m**2) | |||
|
|
|||
There was a problem hiding this comment.
Was the removal of the CS%id_mass_flux = register_diag_field() call intentional? If so, the corresponding post_data(CS%id_mass_flux, ...) call on line 849 should also be removed, and a comment explaining why should be added to the description of the commit.
| if (present(fluxes_in)) call initialize_ice_shelf_fluxes(CS, ocn_grid, US, fluxes_in) | ||
| if (present(fluxes_in)) then | ||
| call initialize_ice_shelf_fluxes(CS, ocn_grid, US, fluxes_in) | ||
| call register_restart_field(fluxes_in%shelf_sfc_mass_flux, "sfc_mass_flux", .true., CS%restart_CSp, & |
There was a problem hiding this comment.
This restart registration is occurring after the call to restore_state() on about line 1900, so fluxes_in%shelf_sfc_mass_flux will not be read from the restart file. Please consider moving this restart registration call earlier in the routine so that it occurs before the call to restore_state(). Also, it might be worthwhile to verify that the restart writes and reads are both working as intended for this new variable, if this has not already been done.
This is the first PR from gfdl-cryopshere group. It includes several changes related to the surface mass flux from the land to the ice sheet,
shelf_sfc_mass_flux. It is now defined in MOM_surface_forcing_gfdl.F90 and its values are passed tofluxes%shelf_sfc_mass_flux. This field can be used in configurations with a static ice sheet. To accommodate that it is now registered as a diagnostic field withCS%active_shelf_dynamics=.false..