+Revise the rescaled units of forces%tau_mag #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised the rescaled units of forces%tau_mag, fluxes%tau_mag and fluxes%tau_mag_gustless from [R Z L T-2 ~> Pa] to [R Z2 T-2 ~> Pa] to avoid the need for further rescaling when this field is used to calculate turbulent friction velocities and TKE fluxes in 29 places. However, this requires the addition of other rescaling factors when forces%tau_mag is set from the wind stresses. A total of 40 rescaling factors were eliminated, while another 36 were added, all where the components of the wind stress are used to calculate the magnitude of the wind stress. Several other internal variables were also rescaled analogously for simplicity. All answers are bitwise identical, but there are changes to the rescaling factors for three elements in a transparent type.
Hallberg-NOAA
added
the
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised the rescaled units of
forces%tau_mag,fluxes%tau_magandfluxes%tau_mag_gustlessfrom[R Z L T-2 ~> Pa]to[R Z2 T-2 ~> Pa]to avoid the need for further rescaling when this field is used to calculate turbulent friction velocities and TKE fluxes in 29 places. However, this requires the addition of other rescaling factors whenforces%tau_magis set from the wind stresses. A total of 40 rescaling factors were eliminated, while another 36 were added, all where the components of the wind stress are used to calculate the magnitude of the wind stress. Several other internal variables were also rescaled analogously for simplicity. Only one of the rescaling factors that were added would be used in any particular configuration, but several of the ones that were removed might have been used in the same configuration. All answers are bitwise identical, but there are changes to the rescaling factors for three elements in a transparent type.