Inline harmonic analysis #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also renamed a few variables in |
Hallberg-NOAA
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
I see how this code could correct a bug in the original implementation, and upon inspection I am not seeing anything that seems problematic. Although we do not have a test case that exercises this code, this is a contribution from the same person who contributed the original version of this diagnostic code, and I trust that the developer has verified that this does correct problems with the original version of this diagnostic. I am therefore approving this change.
Important bug fix:
1) The Cholesky decomposition was operating on entries below
the main diagonal of FtF, whereas in the accumulator of FtF, only
entries along and above the main diagonal were calculated. In this
revision, I modified HA_accum_FtF so that entries below the main
diagonal are accumulated instead.
2) In the accumulator of FtSSH, the first entry for the mean
(zero frequency) is moved out of the loop over different tidal
constituents, so that it is not accumulated multiple times within
a single time step.
Another bug fix: initial state added back to the mean state.
Minor update to HA_solver
Hallberg-NOAA
force-pushed
the
c2xu/harmonic_analysis
branch
from
d399982 to
1c32e40
Compare
kshedstrom
pushed a commit
to ESMG/MOM6
that referenced
this pull request
Dec 10, 2024
* Inline harmonic analysis
Important bug fix:
1) The Cholesky decomposition was operating on entries below
the main diagonal of FtF, whereas in the accumulator of FtF, only
entries along and above the main diagonal were calculated. In this
revision, I modified HA_accum_FtF so that entries below the main
diagonal are accumulated instead.
2) In the accumulator of FtSSH, the first entry for the mean
(zero frequency) is moved out of the loop over different tidal
constituents, so that it is not accumulated multiple times within
a single time step.
* Inline harmonic analysis
Another bug fix: initial state added back to the mean state.
* Inline harmonic analysis
Minor update to HA_solver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important bug fix:
1) The Cholesky decomposition was operating on entries below the main diagonal of FtF, whereas in the accumulator of FtF, only entries along and above the main diagonal were calculated. In this revision, I modified HA_accum_FtF so that entries below the main diagonal are accumulated instead.
2) In the accumulator of FtSSH, the first entry for the mean (zero frequency) is moved out of the loop over different tidal constituents, so that it is not accumulated multiple times within a single time step.