Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change target to pointer and check for association #530

Conversation

raphaeldussin
Copy link

update from #529

attempting to solve problem raised by @gustavo-marques in mom-ocean#1616

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7ef6a57) 37.45% compared to head (78e2c88) 37.45%.

Files Patch % Lines
...parameterizations/vertical/MOM_set_diffusivity.F90 0.00% 0 Missing and 1 partial ⚠️
...rc/parameterizations/vertical/MOM_tidal_mixing.F90 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           dev-gfdl-main-candidate-2023-11-13     #530      +/-   ##
======================================================================
- Coverage                               37.45%   37.45%   -0.01%     
======================================================================
  Files                                     270      270              
  Lines                                   79765    79765              
  Branches                                14831    14833       +2     
======================================================================
- Hits                                    29879    29878       -1     
  Misses                                  44350    44350              
- Partials                                 5536     5537       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alperaltuntas
Copy link

This PR fixes the issue we encountered. Thanks!

@marshallward
Copy link
Member

This passed our regression after merge into the candidate branch: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/21587

I will merge it in once this MacoS FPE issue has gone away (one way or another).

@marshallward marshallward merged commit 40134ed into NOAA-GFDL:dev-gfdl-main-candidate-2023-11-13 Dec 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants