Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-bats testing and repo structure update #322

Open
wants to merge 75 commits into
base: main
Choose a base branch
from

Conversation

underwoo
Copy link
Member

@underwoo underwoo commented Oct 25, 2024

Description
Updated the land_utils application testing so it does not require bats.
Included with this is a new testing framework, which was acquired from
GNU coreutils. This testing framework, while less extensive than
bats, has several built-in features that improve the testing process.

This update also begins the migration of the utilities out of the
postprocessing and tools directories.

Additional fixes in this PR:

  • Use --tags option to git describe to use any tag, not just annotated tags.
  • Add --version options to applications that did not have that option
  • Developed a standard version of text, and allowed it to be callable from C and Fortran applications
  • Fixed land_utils testing to use a compressed land file

Fixes #320 and #321

How Has This Been Tested?
Testing was performed on an Intel Mac, using homebrew for required
libraries (e.g., netCDF) and using make check. I also tested several Linux systems with different OSes (ubuntu and rocky 8).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

underwoo and others added 30 commits October 25, 2024 09:21
Updated the land_utils application testing to not require bats.  Included with this is a new testing framework, which was acquired from GNU coreutils.  This testing framework, while not as extensive as bats, has several built-in features that improve the testing process.

This update also begins the migration of the utilities out of the postpocessing and tools directories.
Add standard version text to -V option for mppnccombine
Add tasks, and configure cspell settings
Include print_version helper program
This has no changes, so it will not build
Other fixes found during testing
Other fixes to allow in-source builds
Next the "cleanup"
Cleaned up comments in tests, and added helper routines for fortran and tests
time_average adds provanance information to the output netcdf file
@underwoo underwoo marked this pull request as ready for review December 11, 2024 19:36
@underwoo
Copy link
Member Author

While I haven't finished all the work on this, I have made a lot of progress. This PR is at 200+ file changes, so I wanted to get the review on this PR started. Not all of the tests are run, as some are expensive and at least one has taken down the GitHub action host. I did ensure that on my Mac that make distcheck works, even running the non-bats expensive tests.

I'll open a new PR to include the remainder of the test migration and possibly move the "tools" applications into the "src" directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove bats as a requirements for testing
1 participant