Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace include fms_platform.h with use platform_mod in mpp unit tests #1616

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

mlee03
Copy link
Contributor

@mlee03 mlee03 commented Nov 25, 2024

Description
In this PR, #include fms_platform.h has been replaced with use platform_mod in several mpp unit tests. This is to avoid compilations when FMS is compiled with --enable-portable-kinds. See issue below for more details.

Fixes #1615

How Has This Been Tested?
Unit tests in test_fms/mpp pass with GCC 14 on the amdbox.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 merged commit 76a6624 into NOAA-GFDL:main Dec 2, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#include fms_platform.h with --enable-portable-kinds
3 participants