-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test failures with ifx due to use of host associated arrays #1606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, what error is being fixed by adding the save
attributes?
Same question as @rem1776. |
Can you rewrite this test to pass the arrays into the subroutines rather than keep them as program level variables? From our group discussions, this seems to be agreed upon as a path forward with this unit test. |
…n subroutine arguement list
…tine to top of contain block to reslove host association issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated my branch and removed the save attribute in favor of passing arrays to subroutine directly
immadeuph=1.0_lkind | ||
weight=1.0_lkind | ||
|
||
end subroutine initialize_arrays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not get rid of initialize_arrays
and initialize these in the declaration statements at the top of the program instead? As a bonus, that would give them an implicit save
attribute.
Description
Adds save attribute to host associated arrays in test_topography and test_diag_integral so that these tests now pass with the ifx compiler.
How Has This Been Tested?
The Topography and Diag_integral unit tests successfully build and pass using the Intel oneAPI 2024.2 IFX compiler on an AMD box.
Checklist:
make distcheck
passes