Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update link for gfdl-cmor tables to main MDTF branch in getinfo.py #79

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jtmims
Copy link
Contributor

@jtmims jtmims commented Oct 23, 2024

The old links used would direct to an older commit of the MDTF repo. This makes changes to the csv files unseen by the CatalogBuilder. The new links direct to what is seen on the main branch.

This is related to issue #77.

Comment on lines +252 to +253
url = "https://raw.githubusercontent.com/NOAA-GFDL/MDTF-diagnostics/refs/heads/main/data/gfdl-cmor-tables/gfdl_to_cmip5_vars.csv"
url2 = "https://raw.githubusercontent.com/NOAA-GFDL/MDTF-diagnostics/refs/heads/main/data/gfdl-cmor-tables/gfdl_to_cmip6_vars.csv"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's interesting for fre cmor reasons... @ceblanton.

relevant to NOAA-GFDL/fre-cli#205

Copy link
Collaborator

@aradhakrishnanGFDL aradhakrishnanGFDL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtmims!

@aradhakrishnanGFDL aradhakrishnanGFDL merged commit 0f18e03 into NOAA-GFDL:main Oct 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants