Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

53 static #75

Merged
merged 15 commits into from
Oct 30, 2024
Merged

53 static #75

merged 15 commits into from
Oct 30, 2024

Conversation

aradhakrishnanGFDL
Copy link
Collaborator

No description provided.

@aradhakrishnanGFDL aradhakrishnanGFDL self-assigned this Oct 21, 2024
@aradhakrishnanGFDL aradhakrishnanGFDL marked this pull request as draft October 21, 2024 20:43
@aradhakrishnanGFDL
Copy link
Collaborator Author

grid_label.1 column - chasing this

@aradhakrishnanGFDL
Copy link
Collaborator Author

@aradhakrishnanGFDL
Copy link
Collaborator Author

My sample output catalogs are here: /home/a1r/tests/static-catalog.json

To test:

1- Review the /home/a1r/tests/static-catalog.csv

2- review or use this notebook
gen_intake_gfdl.create_catalog(input_path=input_path,output_path=output_path) Or you can also run this interactively:

3- Run one interactive test if possible or review usage

gen_intake_gfdl.py /archive/a1r/fre/FMS2024.02_OM5_20240724/CM4.5v01_om5b06_piC_noBLING/gfdl.ncrc5-intel23-prod-openmp/pp/ /home/a1r/tests/ide_cat

Since I used a reduced test-case, other testers can use a larger test and see how it goes.

@aradhakrishnanGFDL aradhakrishnanGFDL marked this pull request as ready for review October 28, 2024 14:20
Copy link
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had two suggestions. One is to limit the grep to '.static.' instead of 'static', and the other is not setting table_id to fx because it might not be fx.

I don't feel that strong about either, but have been bitten by overly expansive greps so many times I think would be good to change.

catalogbuilder/intakebuilder/builderconfig.py Show resolved Hide resolved
catalogbuilder/intakebuilder/getinfo.py Outdated Show resolved Hide resolved
catalogbuilder/intakebuilder/getinfo.py Outdated Show resolved Hide resolved
@aradhakrishnanGFDL
Copy link
Collaborator Author

CI tests failing..... why

@aradhakrishnanGFDL
Copy link
Collaborator Author

It looks like pkg_resources is deprecated and existing CIs that incorporate things that have a dependency on pkg_resources are broken. I included setuptools in environment.yml which seems to make the CI clear now. But.. this may not be the long-term fix.

@ceblanton ceblanton self-requested a review October 30, 2024 20:36
@ceblanton ceblanton merged commit 419252d into NOAA-GFDL:main Oct 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants