-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
53 static #75
53 static #75
Conversation
grid_label.1 column - chasing this |
Here is the static catalog usage https://github.com/aradhakrishnanGFDL/canopy-cats/blob/main/notebooks/statics-catalog-usage.ipynb Here is the notebook used to generate the catalog https://github.com/aradhakrishnanGFDL/canopy-cats/blob/main/notebooks/static_build_example.ipynb |
My sample output catalogs are here: /home/a1r/tests/static-catalog.json To test: 1- Review the /home/a1r/tests/static-catalog.csv 2- review or use this notebook 3- Run one interactive test if possible or review usage
Since I used a reduced test-case, other testers can use a larger test and see how it goes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I had two suggestions. One is to limit the grep to '.static.' instead of 'static', and the other is not setting table_id
to fx
because it might not be fx
.
I don't feel that strong about either, but have been bitten by overly expansive greps so many times I think would be good to change.
CI tests failing..... why |
…wer versions may not be the most stable ones
CI failure, trying to see what the issue is.
It looks like pkg_resources is deprecated and existing CIs that incorporate things that have a dependency on pkg_resources are broken. I included setuptools in environment.yml which seems to make the CI clear now. But.. this may not be the long-term fix. |
No description provided.