Update fims-demo.Rmd

[JonBrodziak]

Replace "new" with "methods::new" on lines 183, 270, 283 of fims-demo.Rmd

What is the feature?

• Syntax for creating survey_fleet_selectivity, maturity, and population needs a change from "new()" to "methods::new()"

How have you implemented the solution?

• Changes made on lines 183, 270, 283.

Does the PR impact any other area of the project, maybe another repo?

• No

[github-actions]

Instructions for code reviewer

Hello reviewer, thanks for taking the time to review this PR!

• Please use this checklist during your review, checking off items that you have verified are complete!
• For PRs that don't make changes to code (e.g., changes to README.md or Github actions workflows), feel free to skip over items on the checklist that are not relevant. Remember it is still important to do a thorough review.
• Then, comment on the pull request with your review indicating where you have questions or changes need to be made before merging.
• Remember to review every line of code you’ve been asked to review, look at the context, make sure you’re improving code health, and compliment developers on good things that they do.
• PR reviews are a great way to learn, so feel free to share your tips and tricks. However, for optional changes (i.e., not required for merging), please include nit: (for nitpicking) before making the suggestion. For example, nit: I prefer using a data.frame() instead of a matrix because...
• Engage with the developer when they respond to comments and check off additional boxes as they become complete so the PR can be merged in when all the tasks are fulfilled. Make it clear when this has been reached by commenting on the PR with something like This PR is now ready to be merged, no changes needed.

Checklist

• The PR is requested to be merged into the appropriate branch (typically main)
• The code is well-designed.
• The functionality is good for the users of the code.
• Any User Interface changes are sensible and look good.
• The code isn’t more complex than it needs to be.
• Code coverage remains high, indicating the new code is tested.
• The developer used clear names for everything.
• Comments are clear and useful, and mostly explain why instead of what.
• Code is appropriately documented (doxygen and roxygen).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.41%. Comparing base (f0d4e76) to head (b366257).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
- Coverage   78.78%   78.41%   -0.38%     
==========================================
  Files          36       36              
  Lines        1975     2043      +68     
  Branches      141      141              
==========================================
+ Hits         1556     1602      +46     
- Misses        376      398      +22     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kellijohnson-NOAA]

Thanks @JonBrodziak for these changes. I have added the task to issue #662 where we will be sure to include those changes into dev. We are no longer taking pull requests to main, instead all development happens in branches based off of dev and once a milestone is complete, then those changes are brought into dev.