Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marine hybrid envar #3041

Open
wants to merge 34 commits into
base: develop
Choose a base branch
from

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Oct 29, 2024

Description

What the title says.
Main features added:

  • A new possible ci test that runs 1.5 cycle of the hybrid envar with the coupled UFS
  • yamls to allow running the hybrid envar GFSv17 prototype at c384/0.25 for the det and C192/0.25 for the ens. members
  • a few bug and dependency fixes to allow cycling with an ensemble
  • an option to turn off the direct insertion of the sea-ice ensemble member analysis/recentering

Issues addressed:

Dependencies:

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES :
    • GDAS NOT SUBMITTED YET
  • Other changes:
    • **requires to stage the low-res ens. IC's ** Issue not submitted yet

How has this been tested?

  • Tested a subset of the global-worflow ci on Hercules and Hera at various stages of the development.
  • Tested the hybrid ens. var. at C48/5.00 and C384/0.25

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

idate: 2021032418
edate: 2021032500
nens: 3
gfs_cyc: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gfs_cyc: 0
interval: 0

ci/cases/pr/C48mx500_hybAOWCDA.yaml Outdated Show resolved Hide resolved
@RussTreadon-NOAA
Copy link
Contributor

WCOSS2 (Cactus) C48mx500_3DVarAOWCDA g-w CI

Install guillaumevernieres:feature/marineenvar at 5c1148a on Cactus using GDASApp feature/marineenvar at 71e9e5f for sorc/gdas.cd. Use test version of spack-stack/1.60 to build sorc/gdas.cd

Prior to launching C48mx500_3DVarAOWCDA g-w CI make the following change in working copy of env/WCOSS2.env

@@ -109,17 +109,17 @@ elif [[ "${step}" = "marinebmat" ]]; then
     export APRUNCFP="${launcher} -n \$ncmd --multi-prog"
     export APRUN_MARINEBMAT="${APRUN_default}"
 
-elif [[ "${step}" = "ocnanalrun" ]]; then
+elif [[ "${step}" = "marineanlvar" ]]; then
 
     export APRUNCFP="${launcher} -n \$ncmd --multi-prog"
 
-    export APRUN_OCNANAL="${APRUN_default}"
+    export APRUN_MARINEANLVAR="${APRUN_default}"
 
-elif [[ "${step}" = "ocnanalchkpt" ]]; then
+elif [[ "${step}" = "marineanlchkpt" ]]; then
 
     export APRUNCFP="${launcher} -n \$ncmd --multi-prog"
 
-    export APRUN_OCNANAL="${APRUN_default}"
+    export APRUN_MARINEANLCHKPT="${APRUN_default}"
 
 elif [[ "${step}" = "ocnanalecen" ]]; then

With these changes in place, successfully run C48mx500_3DVarAOWCDA g-w CI

/lfs/h2/emc/ptmp/russ.treadon/EXPDIR/prwcda_pr3041
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241200        Done    Oct 31 2024 16:30:16    Oct 31 2024 16:50:22
202103241800        Done    Oct 31 2024 16:30:16    Oct 31 2024 19:23:12

The following marine DA jobs successfully ran

202103241800       gdas_prepoceanobs                   159911150           SUCCEEDED                   0         1         182.0
202103241800      gdas_marineanlinit                   159919020           SUCCEEDED                   0         1          25.0
202103241800         gdas_marinebmat                   159918814           SUCCEEDED                   0         1          38.0
202103241800       gdas_marineanlvar                   159919534           SUCCEEDED                   0         1          70.0
202103241800     gdas_marineanlchkpt                   159920276           SUCCEEDED                   0         1          37.0
202103241800     gdas_marineanlfinal                   159920925           SUCCEEDED                   0         1          32.0

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @guillaumevernieres !

@guillaumevernieres
Copy link
Contributor Author

@AndrewEichmann-NOAA feel free to push your wcoss updates here if there are more (as a PR into my branch).

aerorahul
aerorahul previously approved these changes Nov 7, 2024
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@guillaumevernieres
Copy link
Contributor Author

@KateFriedman-NOAA , @WalterKolczynski-NOAA , @aerorahul . This PR needs IC's to be staged (#3117) and PR's in GDASApp and jcb-gdas to be merged before testing. I made a few changes to make this branch work with an up to date develop so your reviews might be stale by now.
I'm un-drafting it, but do not start the ci just yet.

jobs/JGLOBAL_MARINE_ANALYSIS_FINALIZE Outdated Show resolved Hide resolved
workflow/hosts/hercules.yaml Outdated Show resolved Hide resolved
workflow/rocoto/gfs_tasks.py Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the hashes for gfs_utils and verif-global to match develop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. But don't trigger the ci just yet, I need to merge things in other repos first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCNRES is an integer in the config, not a string. Fix the marine EnVAR
6 participants