Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ww3_ufs1.x: fix typo in switch_MPI_OMPH #1323

Conversation

MatthewMasarik-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA commented Nov 20, 2024

Pull Request Summary

Fixes a typo in the switch_MPI_OMPH switches for ww3_ufs1.x regtests.

Description

  • Provide a detailed description of what this PR does.
  • What bug does it fix, or what feature does it add?
    • bug fix.
  • Is a change of answers expected from this PR?
    • No.

Please also include the following information:

  • Add any suggestions for a reviewer
  • Mention any labels that should be added:
    • bug.
  • Are answer changes expected from this PR? Please describe the changes and the reason why in addition to which of the following labels would apply: mod_def change, out_grd change, out_pnt change, restart file change, Regression test
    • No.

Issue(s) addressed

Commit Message

ww3_ufs1.x: fix typo in switch_MPI_OMPH

Check list

Testing

  • How were these changes tested?
    • Matrix regtests: i) develop v. pr branch, ii) pr v. pr.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    • Yes. Just a bug fix, no new feature.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    • hera / intel.
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
    • No change of answers.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

develop v. pr
Note that the unexpected file diffs seen in the ww3_ufs1.x tests are all due to the switch file contents being recorded in the netCDF file global attributes.

**********************************************************************          
********************* non-identical cases ****************************          
**********************************************************************          
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)              
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)         
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)          
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)           
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)          
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)        
mww3_test_03/./work_PR1_MPI_d2                     (9 files differ)             
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (17 files differ)      
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)       
mww3_test_03/./work_PR3_UNO_MPI_d2                     (15 files differ)        
mww3_test_03/./work_PR2_UQ_MPI_d2                     (13 files differ)         
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)        
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)         
mww3_test_09/./work_MPI_ASCII                     (0 files differ)              
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)                 
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)                 
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)                 
ww3_ufs1.1/./work_c_nth                     (1 files differ)                    
ww3_ufs1.2/./work_a                     (4 files differ)                        
ww3_ufs1.2/./work_l                     (1 files differ)                        
ww3_ufs1.2/./work_c                     (3 files differ)                        
ww3_ufs1.2/./work_b                     (4 files differ)                        
ww3_ufs1.3/./work_a                     (7 files differ)                        
                                                                                
**********************************************************************          
************************ identical cases *****************************          
**********************************************************************

dev.v.pr.matrixCompFull.txt
dev.v.pr.matrixDiff.txt
dev.v.pr.matrixCompSummary.txt

pr v. pr
These comparisons confirm no unexpected non-b4bs.

**********************************************************************                                                  
********************* non-identical cases ****************************                                                  
**********************************************************************                                                  
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)                                                 
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)                                                  
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)                                                  
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)                                                
mww3_test_03/./work_PR1_MPI_d2                     (6 files differ)                                                     
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (17 files differ)                                              
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)                                               
mww3_test_03/./work_PR3_UNO_MPI_d2                     (13 files differ)                                                
mww3_test_03/./work_PR2_UQ_MPI_d2                     (13 files differ)                                                 
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)                                                   
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)                                                
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)                                                 
mww3_test_09/./work_MPI_ASCII                     (0 files differ)                                                      
ww3_tp2.10/./work_MPI_OMPH                     (5 files differ)                                                         
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)                                                         
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)                                                         
ww3_ufs1.3/./work_a                     (3 files differ)                                                                
                                                                                                                        
**********************************************************************                                                  
************************ identical cases *****************************                                                  
**********************************************************************

pr.v.pr.matrixCompFull.txt
pr.v.pr.matrixDiff.txt
pr.v.pr.matrixCompSummary.txt

@MatthewMasarik-NOAA MatthewMasarik-NOAA marked this pull request as ready for review November 21, 2024 21:00
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this typo @MatthewMasarik-NOAA !

I have confirmed the same results as you for regression testing:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (9 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (17 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (18 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.1/./work_c_nth                     (1 files differ)
ww3_ufs1.2/./work_a                     (4 files differ)
ww3_ufs1.2/./work_l                     (1 files differ)
ww3_ufs1.2/./work_c                     (3 files differ)
ww3_ufs1.2/./work_b                     (4 files differ)
ww3_ufs1.3/./work_a                     (7 files differ)

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit bd7b90d into NOAA-EMC:develop Nov 25, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants