Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMO v32 update #107

Merged
merged 11 commits into from
Jan 31, 2024
Merged

Conversation

AndrewBenjamin-NOAA
Copy link
Contributor

Builds off of PR#106:

This PR adds new parameters to g2tmpl, from the v32 WMO grib2 update. In addition, the following new tables were added to params_grib2_tbl_new.text:

4.2-2-6
4.2-4-5
4.2-4-10
4.2-20-0
4.2-20-1
4.2-20-2
4.2-20-3

@edwardhartnett
Copy link
Contributor

These conflicts need to be resolved...

@AndrewBenjamin-NOAA
Copy link
Contributor Author

These conflicts need to be resolved...

@edwardhartnett which conflicts are you referring to?

@edwardhartnett
Copy link
Contributor

image

@AndrewBenjamin-NOAA
Copy link
Contributor Author

@edwardhartnett I don't have write access to resolve the conflicts

@AndrewBenjamin-NOAA
Copy link
Contributor Author

@edwardhartnett Is there any way to review these conflicts so that this PR can be closed? I cannot view the conflicts to see what needs to be resolved. I cannot resolve them as I am not the reviewer.

@edwardhartnett
Copy link
Contributor

You have to do a git pull on this branch, then open those two files and find and fix the conflicts. Then do a commit of those changes back to the branch.

@AndrewBenjamin-NOAA
Copy link
Contributor Author

AndrewBenjamin-NOAA commented Jan 26, 2024

You have to do a git pull on this branch, then open those two files and find and fix the conflicts. Then do a commit of those changes back to the branch.

@edwardhartnett I have resolved the conflicts and committed the changes. We should be all set to proceed.

@edwardhartnett
Copy link
Contributor

OK, this is failing due to an intel problem in the CI due to a change in the way that intel distributes their compiler. I will merge this PR and fix that in a separate PR.

Do we need to do a release now?

@edwardhartnett edwardhartnett merged commit 94552b8 into NOAA-EMC:develop Jan 31, 2024
6 of 8 checks passed
@AndrewBenjamin-NOAA AndrewBenjamin-NOAA deleted the wmo_v32_update branch January 31, 2024 17:02
@AndrewBenjamin-NOAA
Copy link
Contributor Author

OK, this is failing due to an intel problem in the CI due to a change in the way that intel distributes their compiler. I will merge this PR and fix that in a separate PR.

Do we need to do a release now?

Yes, we are ready for a release, thank you.

@edwardhartnett
Copy link
Contributor

OK, I don't have a great understanding of this repo, unfortunately, but I believe we have to run some of the fortran programs to take the data from the text files you added to and do something with it.

@jbathegit do you know what has to be done with this repo before a release?

@edwardhartnett
Copy link
Contributor

OK, I have found instructions from Boi in the docs/user_guide.md. (It's not on the docs on the web since he put it in since the last release.)

I'm looking at the instructions now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants