Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible restart write times (restart_fh) #139

Open
wants to merge 3 commits into
base: dev/emc
Choose a base branch
from

Conversation

NickSzapiro-NOAA
Copy link

@NickSzapiro-NOAA NickSzapiro-NOAA commented Aug 28, 2024

This PR enables writing forecast hour defined restarts ("restart_fh") in the same way as space-delimited floating point forecast hours in model_configure attributes, like restart_fh: 0.25 2.5 6 17 24. The current restart_fh in MOM6 is for integer forecast hours. This will allow CMEPS, MOM6, CICE, and WW3 to have option of forecast hour restarts in addition to existing functionality. Restart writes are triggered when input restart_fh forecast hours are evenly divisible by a component's timestep (internally compared in units of integer seconds) and skipped otherwise.

Testing with cpld_control_gfsv17 confirms that restarts are b4b when (1) sharing common times with RESTART_N and (2) instead of RESTART_N. This feature is exercised in ufs-weather-model regression testing (see ufs-community/ufs-weather-model#2419)

@NickSzapiro-NOAA
Copy link
Author

Hi @jiandewang . May I ask if there is any feedback? This works in my testing

@jiandewang
Copy link
Collaborator

@NickSzapiro-NOAA I am out of office at this moment, will get back to you later

@jiandewang
Copy link
Collaborator

@NickSzapiro-NOAA let me ask NCAR folk for a look to make sure it won't have any negative impact on their side

@jiandewang
Copy link
Collaborator

@NickSzapiro-NOAA line 2109, 2126, 2119 and 2139 are too long, it won't pass MOM6 ci test. You need to use continuoue lines to split them.

@jiandewang
Copy link
Collaborator

@NickSzapiro-NOAA try to use force push to minimize commit log history (as suggested by MOM6 group)

@jiandewang
Copy link
Collaborator

jiandewang commented Nov 21, 2024

@NickSzapiro-NOAA can you write a short sentence describing what this PR is doing ? You can phrase in this way:
modify mom-cap.F90 to have the capability of xxxxxxx in UFS that can be configured on top level CMEPS for all components
we will need to do squash merge

@NickSzapiro-NOAA
Copy link
Author

@jiandewang Maybe "Modify mom_cap.F90 so that restart writes can be triggered at any forecast time via UFS configuration as for other components"

@jiandewang
Copy link
Collaborator

@NickSzapiro-NOAA look better than mine. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants