-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible restart write times (restart_fh) #139
base: dev/emc
Are you sure you want to change the base?
Conversation
Hi @jiandewang . May I ask if there is any feedback? This works in my testing |
@NickSzapiro-NOAA I am out of office at this moment, will get back to you later |
@NickSzapiro-NOAA let me ask NCAR folk for a look to make sure it won't have any negative impact on their side |
@NickSzapiro-NOAA line 2109, 2126, 2119 and 2139 are too long, it won't pass MOM6 ci test. You need to use continuoue lines to split them. |
@NickSzapiro-NOAA try to use force push to minimize commit log history (as suggested by MOM6 group) |
e5006af
to
92da0bf
Compare
92da0bf
to
afe000e
Compare
@NickSzapiro-NOAA can you write a short sentence describing what this PR is doing ? You can phrase in this way: |
@jiandewang Maybe "Modify mom_cap.F90 so that restart writes can be triggered at any forecast time via UFS configuration as for other components" |
@NickSzapiro-NOAA look better than mine. Thanks |
This PR enables writing forecast hour defined restarts ("restart_fh") in the same way as space-delimited floating point forecast hours in model_configure attributes, like
restart_fh: 0.25 2.5 6 17 24
. The current restart_fh in MOM6 is for integer forecast hours. This will allow CMEPS, MOM6, CICE, and WW3 to have option of forecast hour restarts in addition to existing functionality. Restart writes are triggered when input restart_fh forecast hours are evenly divisible by a component's timestep (internally compared in units of integer seconds) and skipped otherwise.Testing with cpld_control_gfsv17 confirms that restarts are b4b when (1) sharing common times with RESTART_N and (2) instead of RESTART_N. This feature is exercised in ufs-weather-model regression testing (see ufs-community/ufs-weather-model#2419)