Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hashes for jcb, jcb-algorithms, and jcb-gdas #1190

Merged

Conversation

RussTreadon-NOAA
Copy link
Contributor

The jcb hashes in GDASApp develop currently point at branches. The jcb PRs for the changes in these branches have been processed and all jcb changes are in their respective develop. This PR is opened to update jcb hashes in GDASApp develop to point at the appropriate jcb develop hashes.

Resolves #1189

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Jun 21, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

@CoryMartin-NOAA : This PR is ready for review. A check of the changes shows no change in content. This is correct. The jcb branches to which develop currently points at have been merged into various jcb develop. There is no change in jcb content. Only the hashes for jcb, jcb-algorithms, and jcb-gdas change.

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @RussTreadon-NOAA feel free to merge if you see fit

@RussTreadon-NOAA RussTreadon-NOAA merged commit 4c58b1e into NOAA-EMC:develop Jun 21, 2024
2 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/update_jcb branch June 27, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jcb hashes
2 participants