Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sidebar expansion #279

Merged
merged 8 commits into from
Nov 15, 2024
Merged

Fix/sidebar expansion #279

merged 8 commits into from
Nov 15, 2024

Conversation

MRita443
Copy link
Collaborator

@MRita443 MRita443 commented Mar 28, 2024

Closes #278
Fixes the mobile sidebar not expanding to the bottom of the screen when scrolled.

Screenshots

Review checklist

  • Contains enough appropriate tests
  • Behavior is as expected
  • Clean, well-structured code

@MRita443 MRita443 self-assigned this Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8497122) to head (fc17ecd).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #279   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           16        16           
  Branches         4         4           
=========================================
  Hits            16        16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MRita443 MRita443 requested a review from LuisDuarte1 July 27, 2024 10:43
@MRita443 MRita443 requested a review from rubuy-74 August 31, 2024 10:53
@MRita443
Copy link
Collaborator Author

@rubuy-74 @LuisDuarte1

@MRita443
Copy link
Collaborator Author

This also fixed the background color not extending to the end on scrollable pages

@MRita443
Copy link
Collaborator Author

MRita443 commented Nov 5, 2024

This also fixed the background color not extending to the end on scrollable pages

This seems to no longer be the case with the new updates on develop. If I remove height: 100% from the HTML element though it works. I am not sure why and might open an issue on that

Copy link
Contributor

@rubuy-74 rubuy-74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on the meeting, the problem will be discussed in another issue. Aside from that it is ready for merge.

@MRita443 MRita443 requested a review from rubuy-74 November 15, 2024 18:41
Copy link
Contributor

@rubuy-74 rubuy-74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rubuy-74 rubuy-74 merged commit e8139fc into develop Nov 15, 2024
5 checks passed
@rubuy-74 rubuy-74 deleted the fix/sidebar-expansion branch November 15, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Fix mobile sidebar not expanding to end on scrollable pages
2 participants