-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic faculty selection #815
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niaefeup-admin
force-pushed
the
develop
branch
from
September 1, 2023 11:35
43e6780
to
d2ed63a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #815 +/- ##
======================================
- Coverage 16% 16% -0%
======================================
Files 202 203 +1
Lines 6371 6389 +18
======================================
Hits 986 986
- Misses 5385 5403 +18 |
still need to check if the pct_id is present in accounts of only one faculty |
niaefeup-admin
force-pushed
the
develop
branch
from
October 13, 2023 12:43
1758e7c
to
685f908
Compare
Let's close this since we're avoiding scrapping for now. (And let's wait for federated auth) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #797
This pull request makes the selection of faculties automatic.
For that, there was the need to fetch and parse a page (for example). However, if the user is only in one university, there will occur a redirect to the corresponding faculty page.
There are still some things to solve:
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change