Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic faculty selection #815

Closed
wants to merge 11 commits into from

Conversation

Rica320
Copy link
Contributor

@Rica320 Rica320 commented Jul 2, 2023

Closes #797

This pull request makes the selection of faculties automatic.
For that, there was the need to fetch and parse a page (for example). However, if the user is only in one university, there will occur a redirect to the corresponding faculty page.

There are still some things to solve:

  • the pct_id of the user needs to be found (probably an id in the database or something). This will probably require another fetch as this information is not present in the response body on login
  • there is a lot of dead code to be removed
  • getStudentFaculties can be refactored/removed>

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #815 (fb61515) into develop (0b5ff94) will decrease coverage by 0%.
Report is 2 commits behind head on develop.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           develop   #815   +/-   ##
======================================
- Coverage       16%    16%   -0%     
======================================
  Files          202    203    +1     
  Lines         6371   6389   +18     
======================================
  Hits           986    986           
- Misses        5385   5403   +18     

@Rica320 Rica320 marked this pull request as ready for review October 11, 2023 15:42
@Rica320
Copy link
Contributor Author

Rica320 commented Oct 11, 2023

still need to check if the pct_id is present in accounts of only one faculty

@bdmendes bdmendes marked this pull request as draft December 25, 2023 23:46
@bdmendes
Copy link
Collaborator

bdmendes commented Jan 2, 2024

Let's close this since we're avoiding scrapping for now. (And let's wait for federated auth)

@bdmendes bdmendes closed this Jan 2, 2024
@DGoiana DGoiana deleted the feature/automatic-faculties-checker branch June 19, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make selection of hybrid faculties automatic
5 participants