-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial plausible setup #1038
Conversation
I still need to add widget click detection, but it has proven harder than I initially though, especially since Regarding this PR, the terms and conditions still need to be updated and battery level / connectivity detection still need to be added. |
Also, any clues on how to fix the linting error? @bdmendes @LuisDuarte1 |
|
The linting error is being caused because I added the env file to the pubspec.yml, since I need it to be shipped with the app. It never caused an error because it was never added to the application bundle since the linting configurations changed.
I agree. Who is going to handle this? If this is too sensitive to be discussed in public, you can DM me. |
|
Huuu, I'm not sure, are we? Update: I don't think we are, the GitHub Actions don't touch any .env file. Update 2: We are using flutter_dotenv (https://pub.dev/packages/flutter_dotenv). You are still required to add the .env file to your assets. |
64d0a83
to
7cd75b3
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1038 +/- ##
=======================================
- Coverage 17% 16% -0%
=======================================
Files 212 213 +1
Lines 6472 6535 +63
=======================================
Hits 1044 1044
- Misses 5428 5491 +63 |
32f7114
to
5416985
Compare
7cd82cd
to
9b9c29b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Good work!
Closes #1031.
This pull requests adds analytics collection to uni.
As of now, pageviews are collected using flutter_plausible's
PlausibleNavigatorObserver
, which automatically tracks which routes are being viewed. Clicks and other events will be collected as well, but I am still figuring out what is the best way to go about it.Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change