Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Restaurant Home Card Dialog #1036

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

rubuy-74
Copy link
Contributor

Closes #1000
When a restaurant is favorited for the first time, it is asked if the user want to set the Restaurant Card in the Home Page.
image

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #1036 (0f0c469) into develop (b16515d) will decrease coverage by 0%.
Report is 1 commits behind head on develop.
The diff coverage is 4%.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1036   +/-   ##
=======================================
- Coverage       16%     16%   -0%     
=======================================
  Files          201     201           
  Lines         6361    6388   +27     
=======================================
+ Hits           986     987    +1     
- Misses        5375    5401   +26     

@rubuy-74 rubuy-74 requested review from bdmendes and DGoiana November 24, 2023 14:06
@bdmendes bdmendes force-pushed the feature/restaurant-card-home-dialog branch from cb9147a to 0002627 Compare December 5, 2023 12:59
@rubuy-74 rubuy-74 force-pushed the feature/restaurant-card-home-dialog branch from cb8ef63 to e56e915 Compare December 7, 2023 11:18
@bdmendes
Copy link
Collaborator

bdmendes commented Dec 8, 2023

I am also getting:
image
When adding the card via the popup. Bear in mind that the context of the dialog does not contain the provider.

@rubuy-74 rubuy-74 force-pushed the feature/restaurant-card-home-dialog branch 3 times, most recently from 46de6ed to c2f0c3a Compare December 8, 2023 19:12
@rubuy-74 rubuy-74 requested a review from bdmendes December 8, 2023 19:19
@bdmendes bdmendes force-pushed the feature/restaurant-card-home-dialog branch from c2f0c3a to 0f0c469 Compare December 8, 2023 23:03
Copy link
Collaborator

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well, good job!

Copy link
Collaborator

@DGoiana DGoiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking fine!

@bdmendes bdmendes merged commit 3766f6e into develop Dec 9, 2023
6 checks passed
@bdmendes bdmendes deleted the feature/restaurant-card-home-dialog branch December 9, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favorite restaurant action adds restaurants card to Personal Area
3 participants