fix: Added meals column to the RESTAURANTS table #1380
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1380 +/- ##
=======================================
- Coverage 12% 12% -0%
=======================================
Files 266 266
Lines 7201 7212 +11
=======================================
Hits 806 806
- Misses 6395 6406 +11 |
R0drig0-P
force-pushed
the
fix/meals-column-not-in-restaurant-table
branch
from
2eb7ba4 to
9da87ef
Compare
created a new column named meals and changed the way of inserting the restaurant and meals in the database
R0drig0-P
force-pushed
the
fix/meals-column-not-in-restaurant-table
branch
from
f14947b to
ae1186c
Compare
| @@ -104,7 +111,15 @@ class RestaurantDatabase extends AppDatabase<List<Restaurant>> { | |||
|
|
|||
| /// Insert restaurant and meals in database | |||
| Future<void> insertRestaurant(Transaction txn, Restaurant restaurant) async { | |||
| final id = await txn.insert('RESTAURANTS', restaurant.toJson()); | |||
There was a problem hiding this comment.
If you see the sentry catch (ask permission to enter), the problem originates here because Restaurants table has different attributes than resturant.toJson(). Look at the Restaurant Model, you easily see the meals property, which is defined as @JsonKey.
This problem could be easily fixed if you just remove meals key from restaurant.toJson() returned object and insert the filtered restaurant to database. As you can see, there is another table called meals which will deal with the meals as a one-to-many relationship.
However, since you already started to add meals to restaurants table and we recently implement serialization, we can go further with your solution!
Delete dead code:
- meals table
getRestaurantMealsmethodRestaurant.fromMap(), whereRestaurant.fromJson()already done the job
Make all the adjustments you need to make it work!
Feel free to send me a message on Slack for help
packages/uni_app/lib/controller/local_storage/database/app_restaurant_database.dart
Show resolved
Hide resolved
Closes #1370
Created a new column for meals in RESTAURANTS table and changed the way of inserting the restaurant and meals in the database.
Review checklist
whatsnew/whatsnew-pt-PTchangelog.mdwith the change