-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new restaurants api #1393
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1393 +/- ##
=======================================
+ Coverage 12% 12% +1%
=======================================
Files 264 264
Lines 7245 7270 +25
=======================================
+ Hits 803 807 +4
- Misses 6442 6463 +21 |
…nstead of "peixe" and "salada"
The new menu's API has been implemented. Due to the current front-end implementation restrictions, the old The Special thanks to @AugustoVSoares for the collaboration on this implementation. |
The distinction between lunch and dinner is hard coded, so it always displays "Almoço / Jantar" regardless of the app's language setting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredibly work!! It's so nice to see this finally in UNI.
After this detail, it's ready to 🛫
@@ -46,6 +46,7 @@ class RestaurantDatabase extends AppDatabase<List<Restaurant>> { | |||
return Restaurant( | |||
restaurantId, | |||
map['name'] as String, | |||
map['period'] as String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because you modify the database table, increase its version. Since it's stills in v1, you need to create migration code. Look at #1380
WIP implementation of the new restaurants API.
It includes changes that will be undone before the merge, such as changing the provider to always fetch from the remote and debug print messages.
Currently, the meals page includes every establishment from SASUP, but it uses the menu from the old Excel file.
Closes #1360
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change