Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sentry action could not find version #347

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tomaspalma
Copy link
Member

As per the suggestion in the error message from the sentry action

image

@tomaspalma tomaspalma self-assigned this Nov 30, 2024
Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for tts-fe-preview ready!

Name Link
🔨 Latest commit 488b76c
🔍 Latest deploy log https://app.netlify.com/sites/tts-fe-preview/deploys/674a5754c94c470008d6c84e
😎 Deploy Preview https://deploy-preview-347--tts-fe-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomaspalma tomaspalma requested a review from thePeras November 30, 2024 00:35
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's strange, it should find the version because in develop merge is declare as
VERSION=$(git rev-parse --short HEAD) .

Ignoring will work because sentry automatically assigns the commit hash, but I am worried about main merge where it should be the version of the package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants