fix: class item conflict indicator correct severity #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tts-fe-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tomaspalma
force-pushed
the
fix/conflict-triangle-not-showing-correct-severity
branch
3 times, most recently
from
69d57b1 to
b7f7dae
Compare
thePeras
reviewed
Oct 18, 2024
Comment on lines
+80
to
+92
| const classesConflictSeverity = (first: ClassInfo, second: ClassInfo): number => { | ||
| let maxSeverity = 0; | ||
|
|
||
| for (const slot of first.slots) { | ||
| for (const otherSlot of second.slots) { | ||
| if (schedulesConflict(slot, otherSlot)) { | ||
| maxSeverity = Math.max(maxSeverity, conflictsSeverity(slot, otherSlot)); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return maxSeverity; | ||
| } |
There was a problem hiding this comment.
Suggested change
| const classesConflictSeverity = (first: ClassInfo, second: ClassInfo): number => { | |
| let maxSeverity = 0; | |
| for (const slot of first.slots) { | |
| for (const otherSlot of second.slots) { | |
| if (schedulesConflict(slot, otherSlot)) { | |
| maxSeverity = Math.max(maxSeverity, conflictsSeverity(slot, otherSlot)); | |
| } | |
| } | |
| } | |
| return maxSeverity; | |
| } | |
| const classesConflictSeverity = (first: ClassInfo, second: ClassInfo): number => | |
| first.slots.flatMap(slot => | |
| second.slots | |
| .filter(otherSlot => schedulesConflict(slot, otherSlot)) | |
| .map(otherSlot => conflictsSeverity(slot, otherSlot)) | |
| ).reduce((maxSeverity, severity) => Math.max(maxSeverity, severity), 0); |
Because who needs friends when you have pure functions?
There was a problem hiding this comment.
I understand that the code you presented using a more functional paradigm has less lines but it becomes less readable and harder to debug because if we wanted to console log something inside one of the functions it would be a lot harder.
It is also harder because the majority of the people doesn't know well the workings of reduce.
There was a problem hiding this comment.
That's why we should have PFL in the first year, ahaha
thePeras
approved these changes
Nov 4, 2024
tomaspalma
force-pushed
the
fix/conflict-triangle-not-showing-correct-severity
branch
from
b7f7dae to
5c26622
Compare
tomaspalma
deleted the
fix/conflict-triangle-not-showing-correct-severity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes the logic inside
ClassItemso that in cases like the one described in #313 the triangle shows red instead of yellow.