Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sentry tracing report disabled by default in dev mode #329

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

tomaspalma
Copy link
Member

Closes #328

This takes care of not sending tracing events to sentry when in development.

@tomaspalma tomaspalma self-assigned this Oct 17, 2024
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for tts-fe-preview ready!

Name Link
🔨 Latest commit 39115ab
🔍 Latest deploy log https://app.netlify.com/sites/tts-fe-preview/deploys/672389d9b73a49000808c878
😎 Deploy Preview https://deploy-preview-329--tts-fe-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomaspalma tomaspalma changed the title chore: sentry disabled by default in dev mode chore: sentry tracing report disabled by default in dev mode Oct 17, 2024
@tomaspalma tomaspalma force-pushed the chore/sentry-disabled-dev-default branch from 3fb09df to c4b7546 Compare October 17, 2024 22:29
@tomaspalma tomaspalma requested a review from a team October 17, 2024 22:29
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use just the enabled property.
Read more about here and here

@tomaspalma
Copy link
Member Author

I understand what you're saying but I was not trying to disable it entirely.

The goal was to allow to disable specific features.

This way I can seamlessly test the bug report without sending tracing reports to sentry.

@thePeras
Copy link
Member

I understand what you're saying but I was not trying to disable it entirely.

The goal was to allow to disable specific features.

This way I can seamlessly test the bug report without sending tracing reports to sentry.

Ok, I see

.env.example Show resolved Hide resolved
@tomaspalma tomaspalma force-pushed the chore/sentry-disabled-dev-default branch from c4b7546 to 39115ab Compare October 31, 2024 13:44
@tomaspalma tomaspalma requested a review from thePeras October 31, 2024 13:45
@tomaspalma tomaspalma merged commit 24fb9b0 into develop Oct 31, 2024
5 checks passed
@tomaspalma tomaspalma deleted the chore/sentry-disabled-dev-default branch October 31, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sentry not run by default in dev mode
2 participants