Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move context states to CombinedProvider #252

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Process-ing
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for tts-fe-preview ready!

Name Link
🔨 Latest commit 2b55611
🔍 Latest deploy log https://app.netlify.com/sites/tts-fe-preview/deploys/66c4cd07e10e120008a49699
😎 Deploy Preview https://deploy-preview-252--tts-fe-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Process-ing Process-ing force-pushed the refactor/move-states-to-provider branch from 1229435 to 2b55611 Compare August 20, 2024 17:06
@tomaspalma
Copy link
Member

I will still test it further, but from what I see from the code, I believe the main reasons why you don't see any bugs currently is because there is a difference from the previous commit which was reverted in the develop branch.

In the reverted commit you had moved an useEffect into the CombinedProvider, which you didn't do in this commit, which is probably the reason why this commit works and the other didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants