Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove collapsible on create offer #328

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pedronunes19
Copy link
Member

Offer Creation Advanced Settings are no longer on a collapsible section.
Closes #307

Screenshot from 2023-11-27 17-37-10

@pedronunes19 pedronunes19 force-pushed the feature/remove-collapsible branch 3 times, most recently from cf58210 to 6934c99 Compare November 29, 2023 16:10
@pedronunes19 pedronunes19 force-pushed the feature/remove-collapsible branch from 6934c99 to dfc85ff Compare December 20, 2023 15:46
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (33eb94b) to head (dfc85ff).

❗ Current head dfc85ff differs from pull request most recent head 653f698. Consider uploading reports for the commit 653f698 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #328      +/-   ##
===========================================
- Coverage    89.15%   89.12%   -0.03%     
===========================================
  Files          177      177              
  Lines         3438     3429       -9     
  Branches       869      863       -6     
===========================================
- Hits          3065     3056       -9     
  Misses         373      373              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedronunes19 pedronunes19 force-pushed the feature/remove-collapsible branch from dfc85ff to 653f698 Compare March 6, 2024 17:40
@pedronunes19
Copy link
Member Author

Works on my machine

image

@pedronunes19
Copy link
Member Author

Works on my machine

image

Update: it does not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer Advanced Settings
1 participant