fix: company edit permissions are now validated correctly

NIAEFEUP · Jan 12, 2024 · e96dcf2 · e96dcf2
1 parent 6c79001
commit e96dcf2
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/components/Company/Edit/EditCompanyProfileForm.js b/src/components/Company/Edit/EditCompanyProfileForm.js
@@ -132,7 +132,9 @@ export const EditCompanyController = () => {
 
     const fields = useWatch({ control });
 
-    const shouldRevalidateEditingPermissions = useCallback(() => user?.isAdmin || user?.company?._id === id, [id, user]);
+    const shouldRevalidateEditingPermissions = useCallback(() => {
+        return user?.isAdmin || user?.company?._id === id;
+    }, [id, user]);
 
     const [canEdit, setCanEdit] = useState(undefined);
 
@@ -220,7 +222,7 @@ const EditCompanyProfileForm = ({ title }) => {
 
     const Content = isMobile ? DialogContent : CardContent;
 
-    if (companyError || !canEdit) {
+    if (companyError || canEdit === false) {
         return <Redirect {...redirectProps} />;
     }