-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landing page #15
Landing page #15
Conversation
Hi, awesome work so far! Regarding the implementation, I've noticed that there are some inconsistencies with the mockups, but nothing too major.
|
I have a question about the navbar design. Currently, it is fixed to the top of the page. Making it transparent could lead to visibility issues with the content as users scroll. Should the navbar remain fixed at the top, or should it disappear when scrolling down? |
Hey @jose-carlos-sousa. You don't need to worry about that for now and just leave the navbar transparent and not scrolling with the rest of the page. Either way, I'll ask the image department so that we know the answer when the time to implement the rest of the page comes. |
470169d
to
1a5613e
Compare
1a5613e
to
4d50f65
Compare
Co-authored-by: Tomás Palma <[email protected]>
Co-authored-by: Tomás Palma <[email protected]>
4d50f65
to
c1da259
Compare
Really awesome work 🎉 |
I believe the white bar is now fixed in mobile, do you think that the page being scrollable is an issue? |
It's fine, don't worry! But if any of you is interested in going into webdev in the future, it might be an interesting challenge to solve. Will check out the desktop version later today (mobile looks good) and then do a code review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you! 🎉
@limwa @tomaspalma I am not apporving this PR yet due to my comment, which was not necessarily a change request. Waiting on @ttoino also |
Co-authored-by: Tomás Palma <[email protected]>
…te into feature/landing-page
…te into feature/landing-page
…te into feature/landing-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #1.
Preview: https://website-landing-page.up.railway.app/
During the meeting, there was a doubt about why the background in mobile was stretching so much. This was because all of the components inside of the
<Home>
component were being included in the<div>
where we were putting the background in. Because, as for now, that background as the landing page is only to be present in the<Home>
component, we chose to put a variableshowNavbar
in the<AppLayout>
that defaults totrue
, so that in the<Home>
component we can put that tofalse
and render the<Navbar>
inside of the<Home>
component in order to be able to easily put the background only behind certain elements.We checked the HTML validator and it is valid to have
<nav>
tags inside<main>
. If you come up with a better approach, feel free to say so.