Conda new toolchain #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some specific apple-stuff which is not necessary for osx-conda-builds. To reduce the number of patches add an option directly in the cmake.
looooo
force-pushed
the
conda-new_toolchain
branch
2 times, most recently
from
813d1b9
to
cbc5d6f
Compare
looooo
force-pushed
the
conda-new_toolchain
branch
from
cbc5d6f
to
7f75302
Compare
looooo
commented
May 23, 2019
| @@ -28,20 +28,22 @@ option( ENABLE_CPP_CORE_GUIDELINES_CHECK "Enable cpp core guideline checks on ng | |||
| option( USE_SPDLOG "Enable spd log logging" OFF) | |||
| option( DEBUG_LOG "Enable more debug output (may increase computation time) - only works with USE_SPDLOG=ON" OFF) | |||
| option( CHECK_RANGE "Check array range access, automatically enabled if built in debug mode" OFF) | |||
| option( BUILD_WITH_CONDA "set this to on if the library is compiled with conda-buid" OFF) | |||
| option( DYNAMIC_LINK_PYTHON "set this to OFF for static linking to python" ON) | |||
There was a problem hiding this comment.
the message here is maybe misleading. I guess it should be:
"set this to OFF to not link against python DSO"
|
bump |
|
@mhochsteger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This two commits are necessary to build netgen with conda-forge and the new-toolchain. this is a manually rebased version of #22. I will use this version for a new conda-build if it won't get merged into master.