Layout and minimal changes #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of negligible importance to us but the change to |
|
Super happy with this, ideally want to merge #22 first so there aren't conflicts over layout, it's a good trigger to nudge the relevant people |
metazool
approved these changes
Aug 28, 2024
|
|
||
| # Check if the input is a single image or a batch | ||
| if len(tensor_image.shape) == 3: | ||
| # Single image, add a batch dimension | ||
| tensor_image = tensor_image.unsqueeze(0) | ||
|
|
||
| # Check if CUDA is available and move the tensor to the CUDA device | ||
| if torch.cuda.is_available(): | ||
| tensor_image = tensor_image.cuda() |
There was a problem hiding this comment.
I haven't tested any of this with a GPU machine, i remember you noticing that the model wasn't moved to CUDA when you ran it with GPU available, it's probably better to do that than remove the half-implemented option?
|
|
||
| [tool.jupytext] | ||
| formats = "ipynb,md" | ||
|
|
There was a problem hiding this comment.
Thank you for this incremental refinement, moving to the "src layout" was also on my inward list now I've been convinced of the benefits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collects a small handful of changes which I'm hoping are sufficiently non-contentious to bundle together.
src/layout.[build-system]table topyproject.toml(using setuptools for now)prepare_imagethat moves the tensor to the default cuda device if availableAs a side note, the main motivation was that I was experiencing a few problems just
pip installing the package in editable mode, which made me feel like I was 20 again and unable to figure out why I couldn't import the package I'd just installed. Completing thepyproject.tomland changing tosrc/fixed these issues today, as it happened.