Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI issues with Bootstrap 5 #3898

Merged
merged 14 commits into from
Oct 27, 2021
Merged

Fix UI issues with Bootstrap 5 #3898

merged 14 commits into from
Oct 27, 2021

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Oct 19, 2021 •
edited
Loading

Partially addresses #3896

User changes

  • some small layout improvements

Super User changes

  • none

Admin changes

  • none

System admin changes

  • anet.yml or anet-dictionary.yml needs change
    Replace componentClass: with asA: globally throughout the dictionary.
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten changed the title Fix UI issues Fix UI issues with Bootstrap 5 Oct 19, 2021
@gjvoosten gjvoosten force-pushed the GH-3896-fix-ui-issues branch 4 times, most recently from f20e010 to 2686789 Compare October 21, 2021 07:28
@gjvoosten gjvoosten added the debt label Oct 25, 2021
@gjvoosten gjvoosten marked this pull request as ready for review October 25, 2021 12:01
@gjvoosten gjvoosten force-pushed the GH-3896-fix-ui-issues branch from 851d8bb to 85c3348 Compare October 26, 2021 07:59
@gjvoosten gjvoosten force-pushed the GH-3896-fix-ui-issues branch 2 times, most recently from 7e60962 to 90fdb72 Compare October 27, 2021 07:58
gjvoosten and others added 14 commits October 27, 2021 11:38
@gjvoosten
#3896: Use asA to specify UI components
d621fa7
@gjvoosten
#3896: Don't hard-code what's already specified in the dictionary
94700d3
@gjvoosten
#3896: Discard asA on ReadonlyField
07c6b0c
@gjvoosten
#3896: Show ANET link chooser on top of editor
ddab3ae
@gjvoosten
#3896: Use default button for compact report workflow
cc69c15 
Use the proper font colour for contrast.
Add missing style for "unpublished" state.
Change tabs to spaces.
@gjvoosten
#3896: Make the top margin smaller for e.g. the remove button
da3a7d2
@gjvoosten
#3896: Make Cancel button consistent with the others
dbc6f9c
@gjvoosten
#3896: Consistently use Form.Select for selects
fd4d095
@gjvoosten
#3896: Fix PropType for body
47a85f7 
It can be a JSX element as well as a string.
@gjvoosten
#3896: Partially revert commit 02cba81
f9573a5 
Fixes the problem that the month or year pop-ups for a date input inside a modal dialog would disappear immediately.
Note that this no longer suffers from issue #3565
@gjvoosten
#3896: Fix calendar aggregation error if there are no date fields wit…
8fa803d 
…h values yet
@gjvoosten
#3896: Show assessment modal dialog in front of top bar
e0e5af8 
But behind ANET Link dialog!
@anilsonmez-simsoft @gjvoosten
#3896: Make modals containing rich text editor wider
8021926
@gjvoosten
#3896: Remove obsolete stylesheet
9d3f634 
This one is no longer used, it probably re-appeared due to a merge conflict.
@gjvoosten gjvoosten force-pushed the GH-3896-fix-ui-issues branch from 90fdb72 to 9d3f634 Compare October 27, 2021 09:40
@gjvoosten gjvoosten merged commit d6d1d99 into candidate Oct 27, 2021
@gjvoosten gjvoosten deleted the GH-3896-fix-ui-issues branch October 27, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anilsonmez-simsoft anilsonmez-simsoft anilsonmez-simsoft approved these changes

@asafkaganbezgin asafkaganbezgin Awaiting requested review from asafkaganbezgin

Assignees
No one assigned
Labels
debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjvoosten @anilsonmez-simsoft