Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react monorepo to v17 (major) #3349

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 8, 2020

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
react (source) 16.14.0 -> 17.0.2 age adoption passing confidence
react-dom (source) 16.14.0 -> 17.0.2 age adoption passing confidence
react-is (source) 16.13.1 -> 17.0.2 age adoption passing confidence
react-test-renderer (source) 16.14.0 -> 17.0.2 age adoption passing confidence

Release Notes

facebook/react

v17.0.2

Compare Source

React DOM

v17.0.1

Compare Source

React DOM

v17.0.0

Compare Source

Today, we are releasing React 17!

Learn more about React 17 and how to update to it on the official React blog.

React
React DOM
React DOM Server
React Test Renderer
Concurrent Mode (Experimental)

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the dependencies label Dec 8, 2020
Copy link
Contributor

@cemalettin-work cemalettin-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the event bubbling system changed in v17.0 we may potentially have broken buttons/links. One thing i noticed is that when you login as admin ( "arthur"), "Create" button in the home page doesn't expand the dropdown.

@cemalettin-work
Copy link
Contributor

As it turns out, react-bootstrap dropdown / navdropdown menus don't work after React 17.0

@gjvoosten
Copy link
Collaborator

As it turns out, react-bootstrap dropdown / navdropdown menus don't work after React 17.0

Yes; also see #1979
Anything still using deprecated methods which cannot be upgraded (e.g. react-bootstrap or draft-js) prevents us from upgrading to React 17.

Copy link
Collaborator

@gjvoosten gjvoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 2 times, most recently from e198216 to 6bc6093 Compare April 20, 2021 15:50
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from 6bc6093 to d366204 Compare June 24, 2021 06:56
@midmarch midmarch added the epic label Jul 14, 2021
@midmarch midmarch linked an issue Jul 14, 2021 that may be closed by this pull request
4 tasks
@midmarch midmarch removed the epic label Jul 14, 2021
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from d366204 to e137323 Compare September 21, 2021 13:54
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from e137323 to b55f183 Compare October 13, 2021 11:28
@gjvoosten gjvoosten mentioned this pull request Oct 19, 2021
4 tasks
@gjvoosten gjvoosten self-assigned this Oct 19, 2021
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from b55f183 to 73e0494 Compare October 19, 2021 09:40
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from 73e0494 to e4f904b Compare October 19, 2021 13:39
@gjvoosten gjvoosten merged commit eaac851 into candidate Oct 20, 2021
@gjvoosten gjvoosten deleted the renovate/major-react-monorepo branch October 20, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epic - Update to React v17
4 participants