Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all day report indicators #3071

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Add all day report indicators #3071

wants to merge 10 commits into from

Conversation

ysf-simsoft
Copy link
Contributor

An "All day" checkbox is added to report form. Previously, reports are considered to be all-day events when duration field is left empty (specifically when duration was null). This behavior is preserved while giving an option (by checking all-day checkbox) to the user for explicitly setting the report as an all-day event.

When creating a new report all-day checkbox is initially checked and duration field is disabled. If user enters a time other than 00:00 in date picker, checkbox is automatically cleared and duration field is automatically enabled. At this point, entering a duration is required because time is entered (even though duration is optional initially).

If all-day checkbox gets checked after user enters time and duration, time gets reset to 00:00 (start of day) and duration gets reset to null and duration field gets disabled.

Release notes

Closes #3024

User changes

  • Engagement Date and Duration fields are inlined and an "All Day" checkbox is added next to Duration field in order to give users option to explicitly set a report as an all-day event.

Super User changes

  • none

Admin changes

  • none

System admin changes

  • none

  • anet.yml needs change

  • db needs migration

  • documentation has changed

  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@ysf-simsoft ysf-simsoft added this to the 2020 June milestone Jun 17, 2020
@ysf-simsoft ysf-simsoft force-pushed the GH-3024-add-all-day-report-indicators branch from cfa3e26 to 2d89fb8 Compare June 22, 2020 08:54
@ysf-simsoft ysf-simsoft force-pushed the GH-3024-add-all-day-report-indicators branch from 2d89fb8 to b9eed26 Compare July 24, 2020 09:46
@ysf-simsoft ysf-simsoft force-pushed the GH-3024-add-all-day-report-indicators branch from b9eed26 to b285599 Compare August 22, 2020 19:14
@cemalettin-work cemalettin-work force-pushed the GH-3024-add-all-day-report-indicators branch from b285599 to 673b781 Compare October 12, 2020 11:08
@cemalettin-work cemalettin-work changed the title GH 3024 Add all day report indicators Add all day report indicators Oct 12, 2020
@cemalettin-work cemalettin-work marked this pull request as ready for review October 12, 2020 11:48
@cemalettin-work cemalettin-work requested a review from a team October 12, 2020 11:48
@cemalettin-work
Copy link
Contributor

Currently, the ui looks like this for different places where reports are displayed.
All-day-indicators

@cemalettin-work cemalettin-work self-assigned this Oct 26, 2020
cemalettin-work
cemalettin-work reviewed Oct 26, 2020
View reviewed changes
Copy link
Contributor

@cemalettin-work cemalettin-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add as much places in the ui as possible. Needs a review of where we need to show the indicator and where we don't

@cemalettin-work cemalettin-work force-pushed the GH-3024-add-all-day-report-indicators branch from df1d0d1 to a3f4347 Compare November 19, 2020 08:06
@gjvoosten gjvoosten force-pushed the GH-3024-add-all-day-report-indicators branch from a3f4347 to fc1d60e Compare November 25, 2020 11:17
@cemalettin-work cemalettin-work force-pushed the GH-3024-add-all-day-report-indicators branch 3 times, most recently from 5eea151 to b117e54 Compare November 26, 2020 08:34
@cemalettin-work cemalettin-work force-pushed the GH-3024-add-all-day-report-indicators branch 4 times, most recently from 0ec9c17 to 35b9e9d Compare November 26, 2020 12:01
gjvoosten
gjvoosten requested changes Nov 26, 2020
View reviewed changes
client/src/index.css Show resolved Hide resolved
client/src/pages/reports/EngagementDateFormPartial.js Outdated Show resolved Hide resolved
client/src/models/Report.js Show resolved Hide resolved
@cemalettin-work cemalettin-work force-pushed the GH-3024-add-all-day-report-indicators branch from 35b9e9d to 2c8a389 Compare December 14, 2020 11:48
@cemalettin-work cemalettin-work force-pushed the GH-3024-add-all-day-report-indicators branch from 2c8a389 to 854c338 Compare December 14, 2020 12:08
@cemalettin-work cemalettin-work force-pushed the GH-3024-add-all-day-report-indicators branch from 854c338 to 418d296 Compare December 22, 2020 08:38
ysf-simsoft and others added 10 commits December 28, 2020 09:23
@ysf-simsoft @cemalettin-work
#3024: Extract date and duration fields from report form
edf5ed5 
Move those fields to a dedicated component in order to implement
all-day related features in isolation.
@ysf-simsoft @cemalettin-work
#3024: Make all-day logic more obvious in report form
2043320 
Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.
@cemalettin-work
#3024: Remove unnecessary useEffect logic
33bd153
@cemalettin-work
#3024: Add all day indicators to calendars, maps etc
612af01
@cemalettin-work
#3024: Fix test failing - text formatting, refactoring
bf34355
@cemalettin-work
#3024: Fix Report import by moving report logic
b0f2788
@cemalettin-work
#3024: Improve styling/responsiveness
a87dab2
@cemalettin-work
#3024: Fix tests and import Report issue
fb53fa7
@cemalettin-work
Prevent 0 as duration and fix the test for it
6f6e392
@cemalettin-work
#3024: Remove unnecessary top-level label on small width
1a85940 
Also fine tune column sizes on engagement planning part
@cemalettin-work cemalettin-work force-pushed the GH-3024-add-all-day-report-indicators branch from 418d296 to 1a85940 Compare December 28, 2020 06:23
@gjvoosten gjvoosten requested review from midmarch and removed request for gjvoosten December 23, 2021 13:44
@gjvoosten gjvoosten marked this pull request as draft February 16, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cemalettin-work cemalettin-work cemalettin-work left review comments

@gjvoosten gjvoosten gjvoosten requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2020 June
Development

Successfully merging this pull request may close these issues.

Add all-day report indicators throughout UI
4 participants
@ysf-simsoft @cemalettin-work @gjvoosten @VassilIordanov