Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI issues with Bootstrap 5 #3896

Open
9 of 13 tasks
gjvoosten opened this issue Oct 19, 2021 · 0 comments
Open
9 of 13 tasks

UI issues with Bootstrap 5 #3896

gjvoosten opened this issue Oct 19, 2021 · 0 comments
Labels

Comments

@gjvoosten
Copy link
Collaborator

gjvoosten commented Oct 19, 2021

Remaining items from #3698:

  • Font sizes got bigger throughout the application.
  • BlueprintsJS 'core' library could be omitted (with the possible exception of icons). [current React-Bootstrap library lacks Date&Time picker component].
  • React-Bootstrap offers similar functionality to some extra libraries that we use; we may want to replace those libraries with standard bootstrap.
  • Text in custom field textarea's is vertically aligned in the middle, and newlines can no longer be entered (it looks like those textarea's are rendered not as a textarea but as a regular text input field).
  • The modal triggered by ANET Link button inside RichTextEditor falls behind the modal that RichTextEditor is placed in. See notes section in show pages (there might be other places).
  • AdvancedSingleSelect components inside AdvancedSearch remain inside of the search box when opened.
  • Badges in the CompactRowReportWorkflow don't have enough contrast in the font.
  • The Remove Item button in e.g. the Edit History dialog is too far up.
  • The ReportStateFilter (e.g. advanced search on Insights with only the state as a filter) overlaps the remove button.
  • The checkbox (e.g. advanced search on the Pending Assessments Insight ) is overlapped by the label.
  • Date picker components does not display month and year drop-downs when inside of a modal.
  • "Changes requested" button in the report workflow pop-up can be wider than the pop-up.
  • Assessment modals containing SlateJS editor can be larger so that the toolbar is not wrapped.
@gjvoosten gjvoosten added the debt label Oct 19, 2021
@gjvoosten gjvoosten changed the title Font sizes got bigger throughout the application. UI issues with Bootstrap 5 Oct 19, 2021
gjvoosten added a commit that referenced this issue Oct 19, 2021
@gjvoosten gjvoosten self-assigned this Oct 19, 2021
gjvoosten added a commit that referenced this issue Oct 19, 2021
gjvoosten added a commit that referenced this issue Oct 19, 2021
gjvoosten added a commit that referenced this issue Oct 19, 2021
gjvoosten added a commit that referenced this issue Oct 20, 2021
gjvoosten added a commit that referenced this issue Oct 20, 2021
gjvoosten added a commit that referenced this issue Oct 20, 2021
so the proper font is used for contrast.
gjvoosten added a commit that referenced this issue Oct 20, 2021
Use the proper font colour for contrast.
Add missing style for "unpublished" state.
Change tabs to spaces.
gjvoosten added a commit that referenced this issue Oct 20, 2021
It can be a JSX element as well as a string.
gjvoosten added a commit that referenced this issue Oct 20, 2021
gjvoosten added a commit that referenced this issue Oct 20, 2021
gjvoosten added a commit that referenced this issue Oct 27, 2021
Use the proper font colour for contrast.
Add missing style for "unpublished" state.
Change tabs to spaces.
gjvoosten added a commit that referenced this issue Oct 27, 2021
It can be a JSX element as well as a string.
gjvoosten added a commit that referenced this issue Oct 27, 2021
Fixes the problem that the month or year pop-ups for a date input inside a modal dialog would disappear immediately.
Note that this no longer suffers from issue #3565
gjvoosten added a commit that referenced this issue Oct 27, 2021
Time picker props should now be `undefined` to not show the time picker.
gjvoosten added a commit that referenced this issue Oct 27, 2021
gjvoosten added a commit that referenced this issue Oct 27, 2021
This one is no longer used, it probably re-appeared due to a merge conflict.
gjvoosten added a commit that referenced this issue Oct 27, 2021
gjvoosten added a commit that referenced this issue Oct 27, 2021
gjvoosten added a commit that referenced this issue Oct 27, 2021
Use the proper font colour for contrast.
Add missing style for "unpublished" state.
Change tabs to spaces.
gjvoosten added a commit that referenced this issue Oct 27, 2021
It can be a JSX element as well as a string.
gjvoosten added a commit that referenced this issue Oct 27, 2021
Fixes the problem that the month or year pop-ups for a date input inside a modal dialog would disappear immediately.
Note that this no longer suffers from issue #3565
gjvoosten added a commit that referenced this issue Oct 27, 2021
gjvoosten added a commit that referenced this issue Oct 27, 2021
This one is no longer used, it probably re-appeared due to a merge conflict.
gjvoosten added a commit that referenced this issue Oct 27, 2021
@gjvoosten gjvoosten removed their assignment Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant