#3762: Fix empty html bugs

NCI-Agency · Oct 13, 2021 · 242285c · 242285c
1 parent b7bfc7e
commit 242285c
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/client/src/components/RichTextEditor.js b/client/src/components/RichTextEditor.js
@@ -118,17 +118,18 @@ const serialize = node => {
 }
 
 const deserialize = element => {
-  const children = Array.from(element.childNodes).map(deserialize)
+  let children = Array.from(element.childNodes).map(deserialize)
+  // Body must have at least one children node for user to be able to edit the text in it
+  // Every other node must have a non-empty array of children
+  if (element.nodeName !== "#text" && _isEmpty(children)) {
+    children =
+      element.nodeName === "BODY"
+        ? jsx("element", { type: "paragraph" }, [{ text: "" }])
+        : [{ text: "" }]
+  }
+
   switch (element.nodeName) {
     case "BODY":
-      // Body must have at least one children node for user to be able to edit the text in it
-      if (_isEmpty(children)) {
-        return jsx(
-          "fragment",
-          {},
-          jsx("element", { type: "paragraph" }, [{ text: "" }])
-        )
-      }
       return jsx("fragment", {}, children)
     case "P":
       return jsx("element", { type: "paragraph" }, children)