Allow and deny list #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethmorton
requested changes
May 18, 2022
| operation_services = [] | ||
| runner_parameters = operation.pop("runner_parameters", {}) | ||
| if "allowlist" in runner_parameters.keys(): | ||
| for service in SERVICES[operation["id"]]: |
There was a problem hiding this comment.
We need a safety check here that operation["id"] is present in SERVICES. #36
| if service["id"] in runner_parameters["allowlist"]: | ||
| operation_services.append(service) | ||
| else: | ||
| for service in SERVICES[operation["id"]]: |
| service_operation_responses = [] | ||
| for service in SERVICES[operation["id"]]: | ||
| for service in operation_services: |
There was a problem hiding this comment.
We should have a check prior to this line that we actually have any operation_services. If we don't we should send something helpful. See #36
| @@ -7,9 +7,9 @@ httpcore==0.13.7 | |||
| httpx==0.18.1 | |||
| idna==3.3 | |||
| pydantic==1.9.0 | |||
| reasoner-pydantic==2.1.0 | |||
| reasoner-pydantic==2.2.1 | |||
There was a problem hiding this comment.
A new version of reasoner-pydantic will be out very soon. We might want to wait to merge this until after upgrading.
| @@ -1,4 +1,4 @@ | |||
| fastapi==0.63.0 | |||
| httpx==0.18.1 | |||
| reasoner-pydantic==2.1.0 | |||
| reasoner-pydantic==2.2.1 | |||
There was a problem hiding this comment.
Wait for new version. See above.
|
I think it would be best to address these issues in a separate branch, for tracking purposes. This pull request is an enhancement. I plan on creating a separate pull request to handle bug fixes. |
|
Fair enough. |
kennethmorton
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the usage of the allow and deny list as discussed by the Operations and Workflows Working Group.
Currently, this utilizes the SmartAPI title for the service, as discussed during the last working group meeting. Before merging, it should be decided whether this is really the route to take, or whether or not it is more appropriate to use infores identifiers.