Feat/multi query management #255
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only other thing besides my comments above is that you might want to write and test query updates now, since you're already doing most of the work, vs later. |
np0625
reviewed
Dec 27, 2024
models/Query.mjs
Outdated
| constructor({ | ||
| id = null, | ||
| pk, | ||
| status = 0, |
There was a problem hiding this comment.
I would make the statuses constants via some mechanism like export QUERY_STATUS = Object.freeze({NEW: 0, RUNNING: 1, ...});
services/QueryService.mjs
Outdated
| } | ||
|
|
||
| async getQueryById(qid) { | ||
| return this._queryStore.retrieveUserById(qid); |
There was a problem hiding this comment.
Cut and paste error? should be retrieveQueryBy...
services/QueryService.mjs
Outdated
| } | ||
|
|
||
| async getQueryByPk(pk) { | ||
| return this._queryStore.retrieveUserByPk(pk); |
|
Also, we would now need to make POST /query a privileged request, but keep the GETs unprivileged. We should probably address that in this PR also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.