Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified the retain endpoint #589

Merged
merged 2 commits into from
Mar 5, 2024
Merged

modified the retain endpoint #589

merged 2 commits into from
Mar 5, 2024

Conversation

ShervinAbd92
Copy link
Collaborator

No description provided.

@MarkDWilliams
Copy link
Collaborator

What you have here works, but if I can make a suggestion for efficiency, it would be better to do a select save on just the retain field. Otherwise, we might be saving a lot of data we don't need to.

MarkDWilliams
MarkDWilliams requested changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@MarkDWilliams MarkDWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the .save()s to be selective to just the retain field for efficiency?

@ShervinAbd92 ShervinAbd92 merged commit b88fba1 into master Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDWilliams MarkDWilliams MarkDWilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShervinAbd92 @MarkDWilliams